Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove All Missing Episodes On Refresh #176

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove All Missing Episodes On Refresh #176

wants to merge 3 commits into from

Conversation

scampower3
Copy link
Member

No description provided.

@scampower3 scampower3 added the feature This PR or Issue requests or introduces a new feature label Aug 10, 2024
@scampower3 scampower3 marked this pull request as ready for review August 10, 2024 14:20
@scampower3
Copy link
Member Author

scampower3 commented Aug 10, 2024 •
edited
Loading

@Shadowghost If you can, can you take a look at this? This section of the code sets the virtual season created by the missing episode provider from IsVirtualItem=true to IsVirtualItem=false. Which results in ghost seasons when "Display missing episodes within their series" is unchecked.

@scampower3
Copy link
Member Author

@crobibero Can be released so users don't have to rebuild their entire shows lib for this issue

Shadowghost
Shadowghost approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@Shadowghost Shadowghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently unable to test anything since my own environment is down for the next weeks due to maintenance.
Quite sure that I wasn't the one implementin this virtual -> non-virtual season translation.

@scampower3
Copy link
Member Author

scampower3 commented Aug 10, 2024 •
edited
Loading

It's part of this pr. If you can give a brief explanation, I'll try see if I can do smth about it without burning JF down.😅

@sjorge
Copy link

sjorge commented Aug 10, 2024

It's part of this pr. If you can give a brief explanation, I'll try see if I can do smth about it without burning JF down.😅

Both parts of that have been reverted (sadly causing my issue to resurface)

jellyfin/jellyfin#12356
And
jellyfin/jellyfin#12240

So there is no trace left of the above linked PR in 10.9.9

@sjorge sjorge mentioned this pull request Aug 17, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

@crobibero crobibero Awaiting requested review from crobibero

Assignees
No one assigned
Labels
feature This PR or Issue requests or introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scampower3 @sjorge @Shadowghost